search

iterative / dvc

🦉 ML Experiments and Data Management with Git
https://dvc.org
Apache License 2.0
13.66k stars 1.17k forks source link

add dvc artifacts get --show-url #10423

Closed dberenbaum closed 4 months ago

dberenbaum commented 4 months ago

Closes #10420

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 90.60%. Comparing base (a7c0f6e) to head (a23367d). Report is 1 commits behind head on main.

Files Patch % Lines
dvc/commands/artifacts.py 20.00% 8 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10423 +/- ## ========================================== + Coverage 90.50% 90.60% +0.10% ========================================== Files 502 502 Lines 38982 38992 +10 Branches 5622 5632 +10 ========================================== + Hits 35279 35329 +50 + Misses 3006 2991 -15 + Partials 697 672 -25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tibor-mach commented 4 months ago

This looks good... @dberenbaum does it need the remote git repo access or can it rely on the token? I think that either is fine for the moment but we should clarify that in the docs (since if it needs the repo access it behaves differently than other uses of dvc artifacts get

tibor-mach commented 4 months ago

Can this be merged now?