iterative / dvc

🦉 ML Experiments and Data Management with Git
https://dvc.org
Apache License 2.0
13.36k stars 1.16k forks source link

fix fish shell support #10445

Closed oswdm closed 3 weeks ago

oswdm commented 4 weeks ago

Co-authored-by: Alexey Stern stern.alexey@gmail.com

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 27.27273% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 90.31%. Comparing base (8f8d49d) to head (b3bde77).

Files Patch % Lines
dvc/stage/run.py 27.27% 14 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10445 +/- ## ========================================== - Coverage 90.34% 90.31% -0.03% ========================================== Files 481 481 Lines 35981 35994 +13 Branches 5038 5039 +1 ========================================== + Hits 32506 32508 +2 - Misses 2877 2888 +11 Partials 598 598 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

skshetry commented 3 weeks ago

I added 3702a2c that downgrades a logging message to trace and also caches _fish_supports_no_config result so that we only invoke it once.

skshetry commented 3 weeks ago

Thank you @oswdm for contributing.