search

iterative / dvc

🦉 Data Versioning and ML Experiments
https://dvc.org
Apache License 2.0
13.79k stars 1.18k forks source link

check-ignore: stabilize behavior for subrepos #6001

Open efiop opened 3 years ago

efiop commented 3 years ago

git chec-ignore will error-out if you try to use a path that is in submodule. Seems like dvc check-ignore should do the same with our subrepos.

See https://github.com/iterative/dvc/pull/6000#discussion_r631438598

karajan1001 commented 3 years ago

image

git check-ignore didn't error out but showed null on my computer. But still different than dvc check-ignore

efiop commented 3 years ago

@karajan1001 is subrepo a git submodule?

karajan1001 commented 3 years ago

@karajan1001 is subrepo a git submodule?

Both Git and DVC.

karajan1001 commented 3 years ago

image OK, I know I didn't commit it.

karajan1001 commented 3 years ago 
fatal: ../a.dvc: '../a.dvc' is outside repository at '/Users/gao/Code/test/subrepo/subrepo'

Same condition on files outside repo.