iterative / dvc

🦉 Data Versioning and ML Experiments
https://dvc.org
Apache License 2.0
13.95k stars 1.19k forks source link

dvc queue logs -f could take more then one job_id #8658

Open behrica opened 1 year ago

behrica commented 1 year ago

Similar to "dvc exp run --run-all", which follows the log of all running jobs.

so maybe as simple as:

dvc queue logs -f 107f918,a6ca492

or maybe as options to follow "all running"

dvc queue logs -f all
dberenbaum commented 1 year ago

It could be as simple as dvc queue logs without any args follows all tasks.

dberenbaum commented 1 year ago

This would also be useful as a replacement for dvc exp run --run-all. See https://github.com/iterative/dvc/discussions/8724.

ReveStobinson commented 1 year ago

I agree with this, especially given that dvc exp run --run-all will be deprecated in a future release! The documentation says:

dvc exp run --run-all [--jobs] is now a shortcut for dvc queue start [--jobs] followed by dvc queue logs -f.

However, there isn't actually a set of suitable DVC commands that could replace --run-all without the addition of at least the option suggested by @behrica, since dvc queue logs -f requires exactly one task to be specified.

In that spirit, I would go even further and suggest that an option should also be added to dvc queue start (perhaps --logs, --follow, or --attach), which follows the logs of all of the experiments in the queue (for which I imagine the easiest implementation would be creating a --follow-all option for queue logs and making it a shortcut).

dberenbaum commented 1 year ago

Let's make dvc queue logs show logs for all experiments by default, and then make dvc queue start --follow equivalent to dvc queue start && dvc queue logs --follow.

BradyJ27 commented 11 months ago

Afaik dvc queue logs does NOT show all experiments by default still, and this issue is still valid. Is that correct @dberenbaum ?

dberenbaum commented 11 months ago

Yes, that's correct.