iterative / dvclive

📈 Log and track ML metrics, parameters, models with Git and/or DVC
https://dvc.org/doc/dvclive
Apache License 2.0
167 stars 38 forks source link

callbacks: when to call live.end #487

Closed dberenbaum closed 1 year ago

dberenbaum commented 1 year ago

When combining callbacks with post-callback dvclive calls, it may cause unexpected behavior:

We don't document the context manager along with the callbacks, but it currently seems necessary if making post-callback dvclive calls. When should live.end be called? Should we recommend the context manager even when using callbacks?

daavoo commented 1 year ago

Should we recommend the context manager even when using callbacks?

Yes. Let's have this in mind in any future content. We should try to use it anywhere

For all the framework pages in the docs, we now have an example using context manager. In the example-get-started-experiments notebook, we also use context manager + callback.

Closing this issue and let's open new ones in docs / example-repos-dev if/when needed.