Closed dberenbaum closed 7 months ago
Attention: 30 lines
in your changes are missing coverage. Please review.
Comparison is base (
8406920
) 88.79% compared to head (8e9afeb
) 95.53%. Report is 9 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Docs PR: https://github.com/iterative/dvc.org/pull/4994
The dvclive callback has now been released in both upstream packages:
This one is ready to merge
Tests need an updated version of transformers from https://github.com/huggingface/transformers/pull/27983 to pass
@shcheklein A new hf transformers release was finally published and all tests are now passing. Could you take a look so we can get this merged please?
One item caught my attention - using an internal callback in the notebook. I didn't check also the details of the code.
Fixed that but also found a new issue and will now need to wait for https://github.com/huggingface/transformers/pull/28653 and one more release for the added test to pass âšī¸.
Will take a look after the tests are passing đđģ.
Will take a look after the tests are passing đđģ.
đ Tests pass on the upstream version of transformers
, so just waiting for the next release from them.
@mattseddon The next release of transformers
is out and tests are passing. Do you still want to take a look?
Adds a deprecation notice about the internal HF callback and suggests to use the new external callback, which will be available in the next release of https://github.com/huggingface/transformers.
Also adds the external callback to tests since there weren't similar tests in the transformers library, and updates the example notebook.