iterative / dvclive

📈 Log and track ML metrics, parameters, models with Git and/or DVC
https://dvc.org/doc/dvclive
Apache License 2.0
161 stars 35 forks source link

fix(pyproject): proper reference to the lighting extra #752

Closed shcheklein closed 9 months ago

shcheklein commented 9 months ago

Found a small issue while reviewing https://github.com/iterative/dvclive/pull/749


Thank you for the contribution - we'll try to review it as soon as possible. 🙏

shcheklein commented 9 months ago

Actually, I think it's better to be fixed right in the #749 since we are changing the lighting module there and here CI fails with mypy on it.

dberenbaum commented 9 months ago

@shcheklein What issue did you hit using pytorch-lightning? The codebase tries to be compatible with both lightning and pytorch-lightning, so wondering if there is something we need to address here.

shcheklein commented 9 months ago

I think the dvclive[all] just doesn't install it. Since there is not pytorch-lightning anymore AFAIR.

dberenbaum commented 9 months ago

Okay, I see. It looks like they both still exist but lightning is a superset that includes both pytorch-lightning and fabric. See https://github.com/Lightning-AI/pytorch-lightning/discussions/16688#discussioncomment-6750981.

shcheklein commented 9 months ago

To clarify, I think it us:

tf = ["tensorflow"]
xgb = ["xgboost"]
lgbm = ["lightgbm"]
huggingface = ["transformers", "datasets"]
catalyst = ["catalyst>22"]
fastai = ["fastai"]
lightning = ["lightning>=2.0", "torch"]
optuna = ["optuna"]
all = [
   "dvclive[image,mmcv,tf,xgb,lgbm,huggingface,catalyst,fastai,lightning,optuna,plots,markdown]"
]

mind the lightning and it's definition. all was referring to non-existent extra in our config ASFAIU.

dberenbaum commented 9 months ago

🤦 Got it, thanks for the clarification