Closed mnrozhkov closed 10 months ago
Thanks @mnrozhkov! Very clean and simple. I have just two overall suggestions:
- Try to require numpy and pandas as narrowly as possible
- Drop
columns
since I think users can achieve the same without it
Thanks @dberenbaum! I resolved all comments. Pls, let me know if there are other places to improve 🙌
Thanks @mnrozhkov! Left one last comment and then I think it's ready to merge. Do you plan to also do the docs PR?
Thanks @mnrozhkov! Left one last comment and then I think it's ready to merge. Do you plan to also do the docs PR?
Yes, I plan to update the docs as well.
This PR is a part of this issue: https://github.com/iterative/dvclive/issues/750
Changes:
log_plot()
dvclive/utils.py/convert_datapoints_to_list_of_dicts
pandas
andnumpy
log_plot()
:columns: Optional[List[str]] = None,
- optional list of column names for data in Numpy Array formatJN to test new feature: log_plots.ipynb
TODO