iterative / dvclive

📈 Log and track ML metrics, parameters, models with Git and/or DVC
https://dvc.org/doc/dvclive
Apache License 2.0
165 stars 36 forks source link

Add support for DataFrames and Numpy Arrays for log_plot() #754

Closed mnrozhkov closed 10 months ago

mnrozhkov commented 10 months ago

This PR is a part of this issue: https://github.com/iterative/dvclive/issues/750

Changes:

JN to test new feature: log_plots.ipynb

TODO

mnrozhkov commented 10 months ago

Thanks @mnrozhkov! Very clean and simple. I have just two overall suggestions:

  1. Try to require numpy and pandas as narrowly as possible
  2. Drop columns since I think users can achieve the same without it

Thanks @dberenbaum! I resolved all comments. Pls, let me know if there are other places to improve 🙌

dberenbaum commented 10 months ago

Thanks @mnrozhkov! Left one last comment and then I think it's ready to merge. Do you plan to also do the docs PR?

mnrozhkov commented 10 months ago

Thanks @mnrozhkov! Left one last comment and then I think it's ready to merge. Do you plan to also do the docs PR?

Yes, I plan to update the docs as well.