Closed AlexandreKempf closed 7 months ago
Ah! I understand now why it was not using a formatter already. We cannot use a pre-commit formatter on cookie-cutter projects because the TOML/YAML files are not valid TOML/YAML before the project is initiated. We can keep it for this repo, or we can remove it, as you prefer ;)
@AlexandreKempf Good point, but unless I'm missing something, I still think you could add the changes back to that cookiecutter manually so that:
@dberenbaum I'm wondering if I get you right. Or maybe I wasn't clear enough in my comment.
If I add the formatters in the py-template's pre-commit, it will try to pre-commit the py-template project. Or there are plenty of toml files that are not valid for the formatter (stuff like {%- if cookiecutter.docs != "False" %}
), and at the end, the project refuses to commit my changes.
Is there something I'm missing? What did you have in mind exactly?
Oh my mistake! I putted it outside :( Thanks for the explanation.
I'm doing the PR on py-template
:)
[x] ❗ I have followed the Contributing to DVCLive guide.
[x] 📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.