iterative / dvclive

📈 Log and track ML metrics, parameters, models with Git and/or DVC
https://dvc.org/doc/dvclive
Apache License 2.0
165 stars 36 forks source link

fix ci: account for huggingface transformers changes #781

Closed mattseddon closed 8 months ago

mattseddon commented 8 months ago

Thank you for the contribution - we'll try to review it as soon as possible. 🙏


This PR fixes the test_huggingface_integration test. Check the inline comment for an explanation.

Closes #768

mattseddon commented 8 months ago

My current theory is that a second instance of DVCLiveCallback is being attached to the Trainer.

codecov-commenter commented 8 months ago

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (8406920) 88.79% compared to head (27e38cb) 95.55%. Report is 16 commits behind head on main.

Files Patch % Lines
src/dvclive/fabric.py 82.66% 10 Missing and 3 partials :warning:
tests/frameworks/test_fabric.py 83.33% 6 Missing :warning:
src/dvclive/lightning.py 70.58% 3 Missing and 2 partials :warning:
src/dvclive/utils.py 80.76% 4 Missing and 1 partial :warning:
tests/frameworks/test_lightning.py 94.11% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #781 +/- ## ========================================== + Coverage 88.79% 95.55% +6.75% ========================================== Files 53 55 +2 Lines 3357 3532 +175 Branches 294 314 +20 ========================================== + Hits 2981 3375 +394 + Misses 337 110 -227 - Partials 39 47 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.