Closed dberenbaum closed 5 months ago
My editor with ruff installed from the pyproject.toml and the pre-commit didn't complain. Are you sure you don't have an outdated version of ruff? If you're sure then I don't know why it is a problem on your side and not mine. It is curious.
If you want to merge I have nothing against it.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
aba8807
) 95.55% compared to head (9409f9f
) 95.55%. Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The failure comes from CI, not local, so we would need to check the ruff version there.
The version in the pre-commit does fail:
$ pre-commit run --show-diff-on-failure --color=always --all-files
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check docstring is first.................................................Passed
check that executables have shebangs.................(no files to check)Skipped
check json...............................................................Passed
check for merge conflicts................................................Passed
check toml...............................................................Passed
check yaml...............................................................Passed
debug statements (python)................................................Passed
fix end of files.........................................................Passed
mixed line ending........................................................Passed
sort simple yaml files...............................(no files to check)Skipped
trim trailing whitespace.................................................Passed
codespell................................................................Passed
ruff.....................................................................Failed
- hook id: ruff
- exit code: 1
src/dvclive/live.py:341:9: A003 Class attribute `dir` is shadowing a Python builtin
Found 1 error.
ruff-format..............................................................Passed
Pretty format TOML.......................................................Passed
Pretty format YAML.......................................................Passed
Although the version from the py-template is 0.1.13 which reports the opposite:
$ ruff check src/dvclive/live.py
src/dvclive/live.py:341:28: RUF100 [*] Unused `noqa` directive (unused: `A003`)
Found 1 error.
So maybe we are better off updating the ruff version?
Missed this failure in #783.