search

iterative / dvclive

📈 Log and track ML metrics, parameters, models with Git and/or DVC
https://dvc.org/doc/dvclive
Apache License 2.0
161 stars 33 forks source link

Test studio counter #790

Closed dberenbaum closed 5 months ago

dberenbaum commented 5 months ago

Adds a test for #788. I don't think we need to make a test specific to lightning or threads. The underlying problem is that if dvclive sent plots to studio multiple times with the same step value, only the first value would get sent to studio. Added a test here for that, which fails on main and passes in #788.

dberenbaum commented 5 months ago

@shcheklein Hopefully this helps clarify #788

dberenbaum commented 5 months ago

The changes to the lightning tests just revert what's in #788 since I don't think we need to change any framework-specific tests here

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c0c6199) 95.54% compared to head (238d7dd) 95.53%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## send-to-studio-counter #790 +/- ## ========================================================== - Coverage 95.54% 95.53% -0.02% ========================================================== Files 55 55 Lines 3573 3558 -15 Branches 321 317 -4 ========================================================== - Hits 3414 3399 -15 Misses 111 111 Partials 48 48 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.