Closed ocraft closed 5 months ago
Thanks @ocraft! Ideally, I would like to make title
, x_label
, y_label
, and normalized
all named arguments to log_sklearn_plot()
for a couple reasons:
kwargs
are passed to the underlying sklearn methods, which is inaccurate since it is really a mix of these dvc plot parameters and sklearn args. It would be better to keep these separate rather than rely on this implicit parsing of the kwargs.If you are interested, feel free to try this, but I'm fine to merge without that if it's beyond what you want to take on.
I think that I can do that. Personally, I just expected that log_plot and log_sklearn_plot would have the same arguments; it seemed logical to me.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.52%. Comparing base (
602c053
) to head (c7b66ef
). Report is 10 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@dberenbaum Done :)
Fix for #812