iterative / dvclive

📈 Log and track ML metrics, parameters, models with Git and/or DVC
https://dvc.org/doc/dvclive
Apache License 2.0
163 stars 36 forks source link

Fixes #812 #813

Closed ocraft closed 5 months ago

ocraft commented 5 months ago

Fix for #812

dberenbaum commented 5 months ago

Thanks @ocraft! Ideally, I would like to make title, x_label, y_label, and normalized all named arguments to log_sklearn_plot() for a couple reasons:

  1. It looks like all of these are undocumented and hidden now (I'm curious how you found out how to use them)
  2. The docs state that kwargs are passed to the underlying sklearn methods, which is inaccurate since it is really a mix of these dvc plot parameters and sklearn args. It would be better to keep these separate rather than rely on this implicit parsing of the kwargs.

If you are interested, feel free to try this, but I'm fine to merge without that if it's beyond what you want to take on.

ocraft commented 5 months ago

I think that I can do that. Personally, I just expected that log_plot and log_sklearn_plot would have the same arguments; it seemed logical to me.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.52%. Comparing base (602c053) to head (c7b66ef). Report is 10 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #813 +/- ## ========================================== + Coverage 95.47% 95.52% +0.04% ========================================== Files 57 57 Lines 3889 3951 +62 Branches 353 353 ========================================== + Hits 3713 3774 +61 - Misses 124 125 +1 Partials 52 52 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ocraft commented 5 months ago

@dberenbaum Done :)