Closed iesahin closed 2 years ago
This is mostly done. It may have duplicate files that are better to be removed but I didn't check them before your approval.
generate.bash
$repo
directory in github
is considered a repository to be placed in https://github.com/iterative/$repo
$repo
directory, (e.g. github/repo/experiment
) is considered a branch in this repositorygithub/$repo/$branch/
on top of this as a new branchI didn't add gitlab and bitbucket yet, need to make sure that this is the right approach first.
$hub
is (gitlab, bitbucket) is added by adding a directory to example-cml/$hub
$hub
can have its own URL scheme for git remote
.example-cml/github/$repo
example-cml/github/$repo/$branch
modify-branch.bash
script to example-cml/github/$repo/$branch
directory, it's run before checking in the files. This file is deleted before commit. So if there are modifications that are better be done in a script rather than copying files, you can put them here. There was a branch/with/slashes
in one of the repositories. The above structure is not compatible with branch names with slashes, so I converted it to a branch-with-dashes
.
I didn't use any dvc specific code, only the push script runs dvc push
and I didn't test it yet. (The push script actually pushes all the repositories and please make sure the repositories are ok before using it.)
I didn't add support for tags, but if you need them I can add another level of directories for tags.
This doesn't use any modifications to the committer name and commit date, yet. These can be modified per-hub basis.
Let me know what you think and would like to see here. Thanks.
@casperdcl @iterative/cml @shcheklein
I know you're busy with the release but maybe you have time for a quick review to this one: @casperdcl
ping! @casperdcl :)
ping :)
🙏🏼 Thank you very much, @iesahin! This is an awesome stride in the right direction, and we should review it rather sooner than later.
@casperdcl, like the rest of the team, is a bit busy with releases, but we should track this issue somewhere so it doesn't get lost in the meanwhile.
Please ping @iterative/cml
and @casperdcl as much as you want if you don't hear back from us.
When do you think you could have more time to review this? @iterative/cml
I guess that the answer is going to be “after the release” 🙃
@iesahin I think it's almost impossible to review. Let's split into some baby steps please. One project at a time. 100-500 line PRs if possible ...?
example-cml/github/cml-runner-base-case/expeiment/README.md
s/\(expe\)\(iment\)/\1r\2/g
I think the approach leads to a lot of code (14k lines) which could be avoided...
As per https://github.com/iterative/cml/issues/1000#issuecomment-1124628318, iterative/cml_dvc_case should be updated to replace vl2png ... | cml publish
by vl2png ... > plot.png
and cml publish plot.png
I think with my time constraints until July, I'll close this as is to (maybe) reopen sometime later. Thank you for your reviews.
This one is to add a
generate.bash
script that creates multiple CML example repositories from a single seed repository.Closes #100