iterative / example-repos-dev

Source code and generator scripts for example DVC projects
https://dvc.org/doc
21 stars 13 forks source link

Add mlem get started #109

Closed mike0sv closed 2 years ago

mike0sv commented 2 years ago

Converting this to draft since actual docs are not live on mlem.ai, but any feedback is still welcomed

mike0sv commented 2 years ago
  1. Yes, but this could wait until MLEM release I guess
  2. I am planning to add something like that later, this was for first two sections of get-started https://github.com/iterative/mlem.ai/pull/43/files#diff-1cd29580767fad4637f461df8460373ba6ec523dc598d7d3550657ed56cab101
shcheklein commented 2 years ago

Thanks, @mike0sv for addressing some things. I left a bit more comments, but nothing major.

shcheklein commented 2 years ago

@iterative/mlem hey folks, any progress on this?

mike0sv commented 2 years ago

Since it's already live I think we should go ahead and merge this

shcheklein commented 2 years ago

@mike0sv @aguschin let's cleanup it first please, it has fixture-model-registry for example now besides the get-started project.

aguschin commented 2 years ago

Err, for some reason I committed fixture for GTO here. Removed it.

shcheklein commented 2 years ago

@mike0sv @aguschin did the final review, put some minor questions / comments / bugs - PTAL

aguschin commented 2 years ago

Fixed and resolved some stuff, answered other comments. Waiting for your follow-up on the ones we need to address. @shcheklein

aguschin commented 2 years ago

Ok, now I think I've addressed everything we've discussed, @shcheklein :) If you agree, then please approve the PR.

shcheklein commented 2 years ago

@aguschin thanks! we are getting there :) I still have some questions though. Please see some unresolved comments.

aguschin commented 2 years ago

Thanks for the feedback. Fixed those @shcheklein.

shcheklein commented 2 years ago

@aguschin one unresolved item left - https://github.com/iterative/example-repos-dev/pull/109/files#r919031250 - up to you to address or merge! Good stuff.

aguschin commented 2 years ago

All changes addressed. I've just updated https://github.com/iterative/example-mlem-get-started

Now merging https://github.com/iterative/mlem.ai/pull/132 and https://github.com/iterative/example-repos-dev/pull/109

Thanks for your help and feedback @jorgeorpinel and @shcheklein !