Closed mike0sv closed 2 years ago
Thanks, @mike0sv for addressing some things. I left a bit more comments, but nothing major.
@iterative/mlem hey folks, any progress on this?
Since it's already live I think we should go ahead and merge this
@mike0sv @aguschin let's cleanup it first please, it has fixture-model-registry
for example now besides the get-started
project.
Err, for some reason I committed fixture for GTO here. Removed it.
@mike0sv @aguschin did the final review, put some minor questions / comments / bugs - PTAL
Fixed and resolved some stuff, answered other comments. Waiting for your follow-up on the ones we need to address. @shcheklein
Ok, now I think I've addressed everything we've discussed, @shcheklein :) If you agree, then please approve the PR.
@aguschin thanks! we are getting there :) I still have some questions though. Please see some unresolved comments.
Thanks for the feedback. Fixed those @shcheklein.
@aguschin one unresolved item left - https://github.com/iterative/example-repos-dev/pull/109/files#r919031250 - up to you to address or merge! Good stuff.
All changes addressed. I've just updated https://github.com/iterative/example-mlem-get-started
Now merging https://github.com/iterative/mlem.ai/pull/132 and https://github.com/iterative/example-repos-dev/pull/109
Thanks for your help and feedback @jorgeorpinel and @shcheklein !
Converting this to draft since actual docs are not live on mlem.ai, but any feedback is still welcomed