search

iterative / example-repos-dev

Source code and generator scripts for example DVC projects
https://dvc.org/doc
21 stars 13 forks source link

Fixture for Model Registry with GTO+MLEM+DVC #122

Closed aguschin closed 1 year ago

aguschin commented 2 years ago

This is a fixture that generates bunch of models tracked with GTO, MLEM, DVC or all of those. Not sure it's eventually should be here, but since I generate it using the same approach, it could be the right place.

This is the current result of running it: http://github.com/aguschin/fixture-model-registry

You'll need to use was and azure keys to run it (generate.sh will warn you about this).

shcheklein commented 1 year ago

@aguschin close as stale?

aguschin commented 1 year ago

@shcheklein, let's see if the repo produced by this script is used for Studio. If not, we can close it as stale.

@amritghimire, do you use your fork of https://github.com/aguschin/fixture-model-registry to perform tests for Studio?

If the answer would be "yes", this is going to be useful in future, when we make some breaking changes to GTO and will need to re-generate it (e.g. if we move artifacts.yaml to dvc.yaml).

amritghimire commented 1 year ago

@shcheklein, let's see if the repo produced by this script is used for Studio. If not, we can close it as stale.

@amritghimire, do you use your fork of https://github.com/aguschin/fixture-model-registry to perform tests for Studio?

If the answer would be "yes", this is going to be useful in future, when we make some breaking changes to GTO and will need to re-generate it (e.g. if we move artifacts.yaml to dvc.yaml).

We are using the frozen repo at http://github.com/iterative/fixture-model-registry-frozen for test cases. Its not exactly a fork but the commits and tags were copied from your fixture.

shcheklein commented 1 year ago

@aguschin Q: do we need this still?

aguschin commented 1 year ago

@shcheklein I just re-generated fixture repo for Studio a week ago with this, and it saved us a lot of time (I didn't need to reproduce the repo manually, @amritghimire needed less fixes in tests due to discrepancies in regenerated repo). We may need this in future, I assume. If you don't want this to be here, I can fork a repo and keep this branch on my personal account, while closing PR and removing the branch here. Just let me know if this is preferred.

shcheklein commented 1 year ago

@aguschin no, not at all. I'm all in to merge this if it saves time and it's valuable! I was just asking if we want to make a decision and if this is needed or not. Since it benefits us, let's merge it, wdyt? Do we need to do any additional fixes for this?

aguschin commented 1 year ago

Great @shcheklein! I've updated the branch fixing the feedback you left initially :) Please review and let's merge.

shcheklein commented 1 year ago

Thanks @aguschin !