search

iterative / example-repos-dev

Source code and generator scripts for example DVC projects
https://dvc.org/doc
21 stars 13 forks source link

experiments: use Live(dvcyaml=True) #191

Closed dberenbaum closed 1 year ago

dberenbaum commented 1 year ago

Fixes #190. Unfortunately I haven't been able to regenerate the repo since I don't have GPU access, so I'm leaving this PR in draft mode.

dberenbaum commented 1 year ago

@daavoo @alex000kim Could one of you try this out on the GPU runner when you have a chance so we could merge this PR?

daavoo commented 1 year ago

@daavoo @alex000kim Could one of you try this out on the GPU runner when you have a chance so we could merge this PR?

on it

daavoo commented 1 year ago

Ok, it appears that something might be broken on DVC side when there are 2 dvc.yaml files with top-level stuff. Only one is being collected. 😫

Taking a look

daavoo commented 1 year ago

Ok, it appears that something might be broken on DVC side when there are 2 dvc.yaml files with top-level stuff. Only one is being collected. 😫

Taking a look

I think it was https://github.com/iterative/dvclive/pull/512

daavoo commented 1 year ago

The deployed version already contains these changes (https://github.com/iterative/example-get-started-experiments/blob/main/dvc.yaml) but I was trying to also push the experiments with exp push and failing. Probably no reason to don't merge this P.R.

daavoo commented 1 year ago

The deployed version already contains these changes (https://github.com/iterative/example-get-started-experiments/blob/main/dvc.yaml) but I was trying to also push the experiments with exp push and failing. Probably no reason to don't merge this P.R.

I will still try to generate again and push the experiments

dberenbaum commented 1 year ago

Thanks @daavoo!