iterative / example-repos-dev

Source code and generator scripts for example DVC projects
https://dvc.org/doc
21 stars 13 forks source link

Use log_artifact in notebook. #194

Closed daavoo closed 1 year ago

daavoo commented 1 year ago

Closes #171

It is currently deployed:

Captura de pantalla 2023-04-13 a las 18 02 51
daavoo commented 1 year ago

We should also add log_artifact to train.py, but it's not a blocker if we want to wait until we are ready to add type=model or other MR stuff since it should be a noop now. Do we have that tracked somewhere?

Um. So the model would not be a stage output?

dberenbaum commented 1 year ago

No, the model can still be a stage output, that's why it would be a noop now and I think it's okay to not include it yet. Once log_artifact also adds it to the artifacts section, we will want it inside train.py also. I think it also may confuse users if log_artifact is used in the notebook but not train.py.