iterative / example-repos-dev

Source code and generator scripts for example DVC projects
https://dvc.org/doc
21 stars 13 forks source link

Update README.md to include adding a model to Model Registry #204

Closed aguschin closed 1 year ago

aguschin commented 1 year ago

part of https://github.com/iterative/example-repos-dev/issues/203

aguschin commented 1 year ago

Good question. I failed to re-generate the project (don't have necessary rights I believe), so that wasn't an option for me since I wanted a quick fix 😅

As I see it, the reason to keep it as a manual process is to keep showing Studio in the PR https://github.com/iterative/example-get-started-experiments/pull/126, which is important enough IMO. Once we implement Studio API for adding models, we can make that part of the generation script.

daavoo commented 1 year ago

howing Studio in the PR iterative/example-get-started-experiments#126, which is important enough IMO. Once we implement Studio API for adding models, we can make that part of the generation script.

So the idea is that in the example Repo the P.R. would be left open?

aguschin commented 1 year ago

So the idea is that in the example Repo the P.R. would be left open?

As I see it, yes. Here I just replaced @alex000kim's PR https://github.com/iterative/example-get-started-experiments/pull/112 with my own. I find it the right approach myself to keep it open, but maybe Alex have something to add as well.