search

iterative / example-repos-dev

Source code and generator scripts for example DVC projects
https://dvc.org/doc
21 stars 13 forks source link

fix(example-get-started): avoid inf and nans in prc plot output #226

Closed shcheklein closed 11 months ago

shcheklein commented 11 months ago

Fixes #225

Since we have PRs broken in the example repo https://github.com/iterative/example-get-started/actions/runs/5484365547/job/14852022942?pr=53 and I failed to demo it the last week.

It's a workaround for now. The best fix it work with Vega to fix their CLI - https://github.com/vega/vega-lite/issues/9026. I'm not sure it's a priority at the moment since we have quick workaround if needed, JS version of Vega seems to work fine, and I'm not sure for the long term future of Vega in the project (tbh we need to migrate I think to something else after all as soon as we have more time and resources).

shcheklein commented 11 months ago

Doesn't fix it actually. The reason is in ROC, not in PRC which we don't generate manually atm :(.