iterative / example-repos-dev

Source code and generator scripts for example DVC projects
https://dvc.org/doc
21 stars 13 forks source link

Update to YOLO. Add Sagemaker deployment #229

Closed daavoo closed 11 months ago

daavoo commented 11 months ago

Migrate to YOLO

Make the decision because:

Sagemaker deployment

Not that I am sure the approach here is the best but at least we could start the discussion. Create https://www.notion.so/iterative/Sagemaker-Deployment-fce94fa0d81c44f395c10fc32940ab82#f3773819ebce4659ad397ed92686d56c to discuss.


TODO:

shcheklein commented 11 months ago

@daavoo could you point me please to some details / summary or update the description please - e.g. why YOLO (do we want / do we use the callback there?), what else has changed any why, etc. That make it easier for me to review. Thanks!

shcheklein commented 11 months ago

@daavoo

Make the decision because:

thanks for clarifying this. does it make it easier to deploy? I wonder if those changes are related at all to each other? could have we done them one my one? (easier to review, etc)

daavoo commented 11 months ago

thanks for clarifying this. does it make it easier to deploy?

I found a working example of YOLO + Sagemaker that I could adapt but I did not find that for fast.ai

I wonder if those changes are related at all to each other? could have we done them one my one? (easier to review, etc)

I can split into 2 parts. Yolo and then sagemaker

shcheklein commented 11 months ago

I found a working example of YOLO + Sagemaker that I could adapt but I did not find that for fast.ai

make sense. Nw, let's keep it as is.

daavoo commented 11 months ago

May be it's worth splitting this indeed to unblock it faster. I like that we are trying yolo, it make it more useful for actual customers and scenarios, but it seems we need to do some homework for that to look decent / simple to use and something that can fit into get started docs for the experiments. I would love to hear @dberenbaum opinion as well. May be we should do a leap of faith and just push though it and learn from it and keep doing improvements, etc. Let's decide on this. Duplication and complexity (e.g. custom logger) bothers me in this case.

Moved the YOLO part to https://github.com/iterative/example-repos-dev/pull/232 . Tried to simplify (removed custom callback; sent patch upstream).