search

iterative / example-repos-dev

Source code and generator scripts for example DVC projects
https://dvc.org/doc
21 stars 13 forks source link

Remove stage from model name #236

Closed tapadipti closed 10 months ago

tapadipti commented 10 months ago

As discussed here

dberenbaum commented 10 months ago

Hi @tapadipti, per the linked discussion, WDYT of dropping the version instead of the stage?

tapadipti commented 10 months ago

@dberenbaum This is about creating one SageMaker model per version. This one should be per version, not per stage. So that when we deploy the same model version to different stages, SageMaker does not create separate models for them.

I'm not entirely sure if this change works, coz I haven't tried it. I made it based on what @daavoo said would work. I meant to request your (and @shcheklein's) review in a different PR. I added it to this PR by mistake.

What we need per stage is the endpoint, which @daavoo said he would update in the code.

daavoo commented 10 months ago

I'm not entirely sure if this change works, coz I haven't tried it. I made it based on what @daavoo said would work. I meant to request your (and @shcheklein's) review in a different PR. I added it to this PR by mistake.

The P.R. doesn't currently work as expected because the composed_name is used also for create_endpoint. 2 different names should be built from the inputs. I will update in a different P.R.