iterative / example-repos-dev

Source code and generator scripts for example DVC projects
https://dvc.org/doc
21 stars 13 forks source link

Don't run dvc-studio.yml on tag push, coz otherwise MR version and st… #237

Closed tapadipti closed 10 months ago

tapadipti commented 10 months ago

…age assignment actions trigger this workflow

dberenbaum commented 10 months ago

Sorry, I think I misunderstood the workflow here. Aren't version and stage updates when the action should be triggered? Like in https://github.com/iterative/example-gto/blob/main/.github/workflows/gto-act-on-tags.yml?

daavoo commented 10 months ago

Sorry, I think I misunderstood the workflow here. Aren't version and stage updates when the action should be triggered? Like in https://github.com/iterative/example-gto/blob/main/.github/workflows/gto-act-on-tags.yml?

This change is for the workflow that runs an experiment

tapadipti commented 10 months ago

Aren't version and stage updates when the action should be triggered?

We could trigger the action on both user actions - version registration and stage assignment - or just on stage assignment.

The convention we are following is that when a user assigns a stage, they intend to deploy the model to that stage. So, we create the endpoint during this user action. This step requires the SageMaker model to have been created.

The SageMaker model itself could be created at one of the following two points:

Accordingly, we could trigger the GH action during version registration and stage assignment, or only during stage assignment.

Does this answer your question @dberenbaum

tapadipti commented 10 months ago

Also, I didn't check which PR you had added your question in. So, I guess @daavoo's reply was enough. Anyway, I hope the above explanation doesn't hurt either 😄