search

iterative / gto

🏷️ Git Tag Ops. Turn your Git repository into Artifact Registry or Model Registry.
https://dvc.org/doc/gto
Apache License 2.0
142 stars 16 forks source link

gto annotate and remove support auto push and remote repo #292

Closed francesco086 closed 2 years ago

francesco086 commented 2 years ago

Contribute to https://github.com/iterative/gto/issues/25

francesco086 commented 2 years ago

I apologize upfront for some terrible names like push_on_auto_push (it hurts my eyes)... but functionalities should be there.

Will go on on Monday

codecov-commenter commented 2 years ago

Codecov Report

Base: 86.52% // Head: 86.71% // Increases project coverage by +0.19% :tada:

Coverage data is based on head (427f615) compared to base (86666cb). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #292 +/- ## ========================================== + Coverage 86.52% 86.71% +0.19% ========================================== Files 16 16 Lines 1996 2025 +29 ========================================== + Hits 1727 1756 +29 Misses 269 269 ``` | [Impacted Files](https://codecov.io/gh/iterative/gto/pull/292?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iterative) | Coverage Δ | | |---|---|---| | [gto/api.py](https://codecov.io/gh/iterative/gto/pull/292/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iterative#diff-Z3RvL2FwaS5weQ==) | `93.87% <100.00%> (+0.49%)` | :arrow_up: | | [gto/cli.py](https://codecov.io/gh/iterative/gto/pull/292/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iterative#diff-Z3RvL2NsaS5weQ==) | `73.02% <100.00%> (+0.08%)` | :arrow_up: | | [gto/git\_utils.py](https://codecov.io/gh/iterative/gto/pull/292/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iterative#diff-Z3RvL2dpdF91dGlscy5weQ==) | `99.27% <100.00%> (+0.10%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iterative). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iterative)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

francesco086 commented 2 years ago

TODO: catch the error in case git push fails and display a user friendly message.

francesco086 commented 2 years ago

@aguschin do you have any clue about the errors happening for windows? I am quite clueless tbh...

francesco086 commented 2 years ago

TODO: catch the error in case git push fails and display a user friendly message.

done

francesco086 commented 2 years ago

@aguschin do you have any clue about the errors happening for windows? I am quite clueless tbh...

Issue with windows with py3.8 got solved "on its own" - today the run was successful.

Issue with windows with py3.9 got solved with this fixture: https://github.com/iterative/gto/pull/292/commits/e1432ea5b0c9f21e41c214404d2c7e34cb7901eb (I set it to the default value on my mac)

aguschin commented 2 years ago

Ok, congrats @francesco086 :) everything is there and working now, although the refactoring will surely help 😅

francesco086 commented 2 years ago

Ahah! totally, I am very unsatisfied as of now!