iterative / gto

🏷️ Git Tag Ops. Turn your Git repository into Artifact Registry or Model Registry.
https://dvc.org/doc/gto
Apache License 2.0
140 stars 16 forks source link

Allow passing `ref` to `api._show_versions` #362

Closed aguschin closed 1 year ago

aguschin commented 1 year ago

Bare minimum needed for https://github.com/iterative/mlem/issues/665

- [ ] Allow passing `refs`, getting right version
- [ ] Add tests

Overall, feels like GTO codebase needs a refactoring... While working on this I started with #361, and it's tough to add anything like that without rewriting big chunks of GTO now. There are many things each stepping on other's toes... Plus many implementation decisions were made taking annotations into account, which is no longer a thing in GTO, except for some API for Studio to enable backward compatibility while making updates easier. They should be thrown away to make it easier to contribute new features 🪣

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 94.73% and project coverage change: +0.21 :tada:

Comparison is base (27c2355) 85.15% compared to head (6b90b35) 85.37%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #362 +/- ## ========================================== + Coverage 85.15% 85.37% +0.21% ========================================== Files 18 18 Lines 2115 2126 +11 ========================================== + Hits 1801 1815 +14 + Misses 314 311 -3 ``` | [Impacted Files](https://app.codecov.io/gh/iterative/gto/pull/362?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iterative) | Coverage Δ | | |---|---|---| | [gto/api.py](https://app.codecov.io/gh/iterative/gto/pull/362?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iterative#diff-Z3RvL2FwaS5weQ==) | `89.51% <94.73%> (+0.11%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/iterative/gto/pull/362/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=iterative)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.