iterative / gto

🏷️ Git Tag Ops. Turn your Git repository into Artifact Registry or Model Registry.
https://dvc.org/doc/gto
Apache License 2.0
140 stars 16 forks source link

Make "v" in "v1.2.3" optional #376

Open d-miketa opened 1 year ago

d-miketa commented 1 year ago

Hi,

Would it be possible to make the "v" in "v1.2.3" optional? It's not strict semver. https://semver.org/#is-v123-a-semantic-version

Thanks! :)

aguschin commented 1 year ago

Hi @d-miketa! We discussed this a while ago, and decided to keep v https://github.com/iterative/gto/issues/127#issuecomment-1103815257

It makes sense to keep GTO tags in a single format (not supporting it with v and without) both for simplicity of what you can expect to see and different corner cases that may arise, so I wonder, is it just something that doesn't look right (since it's not vanilla semver) or it block some scenarios for you?

d-miketa commented 1 year ago

Hi @aguschin :)

Thanks for that link, I'll give it a careful read. In the meantime, I can explain where I'm coming from.

I'm not aware of any strict incompatibility with another tool. My request is motivated purely by trying to put together a nice UX that's as consistent as possible - and our Python packages are indexed with regular semver. So it's less that it doesn't look right (an aesthetic concern) and more that I'll have to explain to other users, who don't know gto, that there is a special convention they have to follow for exactly one step in a multi-step process. This creates friction and opportunities for user errors. I'd rather get ahead of the support tickets and use consistent versioning across all steps.