Closed pmrowla closed 1 year ago
Patch coverage: 83.75%
and project coverage change: +0.10%
:tada:
Comparison is base (
73b1dfb
) 85.36% compared to head (8fe0e3c
) 85.47%. Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
DVC officially, supports Python 3.8 through 3.11 but GTO CI is only run against 3.8 through 3.10 (GTO CI fails if you enable 3.11). As far as I can tell, the 3.11 failure is because GTO requires outdated pylint and mypy installations that are just broken on 3.11. The actual test suite passes in 3.11.
IMO there is a lot more work that needs to be done in GTO to bring it in line with current DVC and iterative/py-template
standards, but for the time being I am leaving all of that alone (GTO codebase fails pylint/mypy checks after updating and enabling the py-template or DVC configurations for those tools)
Making GTO pass current mypy/pylint may also require updating other deps (and updating pydantic may require migrating from pydantic v1 to v2 - https://github.com/iterative/gto/pull/375)
This PR will require changes in studio - gitpython instances can no longer be passed into the GTO calls (cc @amritghimire)
Thanks, I can look into it once It gets merged.
related: https://github.com/iterative/dvc/issues/9100
Should fix https://github.com/iterative/gto/issues/369 Fixes https://github.com/iterative/gto/issues/308
Public facing
gto.api
interface has not changed in this PR, but internal GTO API has changed. Ideally these changes should probably be released as a major version bump.This PR will require changes in studio - gitpython instances can no longer be passed into the GTO calls (cc @amritghimire)