iterative / gto

🏷️ Git Tag Ops. Turn your Git repository into Artifact Registry or Model Registry.
https://dvc.org/doc/gto
Apache License 2.0
140 stars 16 forks source link

Remove unnecessary pylint skip comments #394

Closed sweep-ai[bot] closed 1 year ago

sweep-ai[bot] commented 1 year ago

Description

This PR removes unnecessary pylint skip comments from the codebase in the gto/ directory. Pylint skip comments are used to ignore certain rules or checks for a particular line or block of code. However, over time, these comments can become unnecessary and redundant. Removing them helps in maintaining the cleanliness of the code and ensuring that all parts of the code are properly linted.

Summary of Changes

Please review and merge this PR.

Fixes #392.


To checkout this PR branch, run the following command in your terminal:

git checkout {pull_request.branch_name}

🎉 Latest improvements to Sweep:


💡 To get Sweep to edit this pull request, you can:

sweep-ai[bot] commented 1 year ago

GitHub actions yielded the following error.

The relevant lines from the logs for debugging are:

pylint...................................................................Failed
- hook id: pylint
- duration: 34.71s
- exit code: 12

------------------------------------
Your code has been rated at 10.00/10

************* Module gto.api
gto/api.py:406:0: R0914: Too many local variables (22/15) (too-many-locals)
************* Module gto.cli
gto/cli.py:246:0: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
gto/cli.py:681:0: R0914: Too many local variables (16/15) (too-many-locals)
gto/cli.py:811:8: W0212: Access to a protected member _get_state of a client class (protected-access)

The command that failed is: pre-commit run pylint -a -v --show-diff-on-failure.

There are a lot of errors. This is likely due to a small parsing issue or a missing import with the files changed in the PR.

This is likely a linting or type-checking issue with the source code. Update the code changed by the PR. Don't modify the existing tests.

I'm getting the same errors 3 times in a row, so I will stop working on fixing this PR.