iterative / gto

🏷️ Git Tag Ops. Turn your Git repository into Artifact Registry or Model Registry.
https://dvc.org/doc/gto
Apache License 2.0
142 stars 16 forks source link

Update pylint version and fix failing tests #396

Closed sweep-ai[bot] closed 1 year ago

sweep-ai[bot] commented 1 year ago

Description

This PR updates the version of pylint in the setup.py file to the latest version. It also fixes the failing tests that occurred due to the updated linting rules. The code in the gto/ directory has been modified to comply with the new or updated rules.

Summary of Changes

Please review and merge this PR to ensure that the project is up to date with the latest pylint version and that all tests pass successfully.

Fixes #385.


To checkout this PR branch, run the following command in your terminal:

git checkout sweep/update-pylint-version_1

🎉 Latest improvements to Sweep:


💡 To get Sweep to edit this pull request, you can:

sweep-ai[bot] commented 1 year ago

GitHub actions yielded the following error.

The relevant lines from the logs for the failed command "pre-commit run pylint -a -v --show-diff-on-failure" are:

Using config file /home/runner/work/gto/gto/.pylintrc
************* Module /home/runner/work/gto/gto/.pylintrc
.pylintrc:1:0: R0022: Useless option value for '--disable', 'print-statement' was removed from pylint, see https://github.com/pylint-dev/pylint/pull/4942. (useless-option-value)

And for the failed command "pre-commit run pylint -a -v --show-diff-on-failure" on Windows:

Using config file /home/runner/work/gto/gto/.pylintrc
************* Module D:\a\gto\gto\.pylintrc
.pylintrc:1:0: R0022: Useless option value for '--disable', 'print-statement' was removed from pylint, see https://github.com/pylint-dev/pylint/pull/4942. (useless-option-value)

These lines indicate that there is a useless option value for '--disable' in the .pylintrc file.

There are a lot of errors. This is likely due to a small parsing issue or a missing import with the files changed in the PR.

This is likely a linting or type-checking issue with the source code. Update the code changed by the PR. Don't modify the existing tests.

I'm getting the same errors 3 times in a row, so I will stop working on fixing this PR.