search

iterative / gto

🏷️ Git Tag Ops. Turn your Git repository into Artifact Registry or Model Registry.
https://dvc.org/doc/gto
Apache License 2.0
140 stars 16 forks source link

change artifact name regex #398

Closed dberenbaum closed 1 year ago

dberenbaum commented 1 year ago

~Having an issue with tests, but opening this for discussion in the meantime.~

The PR adds support for uppercase letters and _. I decided against support for . because there are some restrictions around how it can be used in git refs.

Related: https://github.com/iterative/dvc/issues/9821

TODO:

dberenbaum commented 1 year ago

@aguschin Do you mind reviewing when you have a chance?

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
gto/constants.py 100.00%

:loudspeaker: Thoughts on this report? Let us know!.