search

iterative / gto

🏷️ Git Tag Ops. Turn your Git repository into Artifact Registry or Model Registry.
https://dvc.org/doc/gto
Apache License 2.0
140 stars 16 forks source link

update GTO to be in line with iterative/py-template standards #400

Closed pmrowla closed 1 year ago

pmrowla commented 1 year ago 
          DVC officially, supports Python 3.8 through 3.11 but GTO CI is only run against 3.8 through 3.10 (GTO CI fails if you enable 3.11). As far as I can tell, the 3.11 failure is because GTO requires outdated pylint and mypy installations that are just broken on 3.11. The actual test suite passes in 3.11.

IMO there is a lot more work that needs to be done in GTO to bring it in line with current DVC and iterative/py-template standards, but for the time being I am leaving all of that alone (GTO codebase fails pylint/mypy checks after updating and enabling the py-template or DVC configurations for those tools)

Making GTO pass current mypy/pylint may also require updating other deps (and updating pydantic may require migrating from pydantic v1 to v2 - https://github.com/iterative/gto/pull/375)

Originally posted by @pmrowla in https://github.com/iterative/gto/issues/378#issuecomment-1672866569

shcheklein commented 1 year ago

I think we've updated pydantic, also it runs on 3.11. What else do we usually need to get it to py-template?

pmrowla commented 1 year ago

This can be closed, issues were all addressed in:

shcheklein commented 1 year ago

Thanks, Peter. Do we want / need to upgrade it to py template?

pmrowla commented 1 year ago

There isn't really a straightforward way to retroactively apply a cookiecutter/cruft template on top of an existing git repo, so any major changes that are made in py-template in the future would need to be done manually in GTO.