search

iterative / gto

🏷️ Git Tag Ops. Turn your Git repository into Artifact Registry or Model Registry.
https://dvc.org/doc/gto
Apache License 2.0
140 stars 16 forks source link

Bump pylint, pydantic, remove "artifacts.yaml" logic #401

Closed aguschin closed 1 year ago

aguschin commented 1 year ago

👀

This will require Studio BE update - we need to remove old logic that works with artifacts.yaml - that will make Studio MR backend codebase more easy to work with! To clarify, before we already removed "write" access to old artifacts.yaml, but kept "read" access. Now we remove "read" access as well. (Please notice, that will lead to some users losing info about model versions that are 3+ months old, but I hope that's ok).

So once this merged, consider bumping major or minor version, but not the patch.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage is 96.87% of modified lines.

Files Changed Coverage
gto/api.py ø
gto/cli.py 0.00%
gto/utils.py ø
gto/config.py 96.66%
gto/__init__.py 100.00%
gto/base.py 100.00%
gto/git_utils.py 100.00%
gto/registry.py 100.00%
gto/tag.py 100.00%

:loudspeaker: Thoughts on this report? Let us know!.

aguschin commented 1 year ago

cc @amritghimire about changes required in BE ^

aguschin commented 1 year ago

@pmrowla, I assume this is what you meant to make it compatible with py-template. There are few things still that should be fixed - like remove top-level silence statements here https://github.com/iterative/gto/blob/bumping-versions/gto/config.py#L1, but overall it should be ready for py-template I hope!

aguschin commented 1 year ago

closes https://github.com/iterative/gto/issues/400

shcheklein commented 1 year ago

Since studio depends for now on MLEM and MLEM depends on the first Pydantic, will those co-exist fine together or does it means we need to upgrade / drop MLEM dependency?

skshetry commented 1 year ago

We discussed this in today's team meeting and decided not to merge this PR due to the breakages involved. We don't want to risk merging this for now.

Most of the pylint/mypy changes has been cherry-picked into the main branch, and CI is now running from Python 3.8 - 3.11 versions now.

I have created #413 that supports both Pydantic v1 and v2, so there's no immediate need to migrate to use pydantic v2 APIs too.

(For future reference, afddc5e8f is the last commit before it was rebased).