fix(registry): push to remote automatically only on cloned repos

iterative / gto

🏷️ Git Tag Ops. Turn your Git repository into Artifact Registry or Model Registry.

https://dvc.org/doc/gto

Apache License 2.0

140 stars 16 forks source link

fix(registry): push to remote automatically only on cloned repos #417

Closed shcheklein closed 1 year ago

shcheklein commented 1 year ago

Fixes #405

We've changed the semantic of the operation during the recent migration to scmrepo. The key thing is the has_remote(reg.scm) calls and implementation. I think the original intention was to push automatically when we run GTO operations on a remote repo (means we are cloning it into a temp dir, do some op, and push the result back).

TODO

[x] Tests
[x] Review CLI option description
[x] Review docs

Docs

Relevant docs update is here https://github.com/iterative/dvc.org/pull/4879

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed	Coverage
gto/api.py	`ø`
gto/cli.py	`ø`
gto/git_utils.py	`100.00%`
gto/index.py	`100.00%`
gto/registry.py	`100.00%`

:loudspeaker: Thoughts on this report? Let us know!.

pmrowla commented 1 year ago

LGTM, I'm ok with merging this and doing tests in a follow up if a customer needs the fix

shcheklein commented 1 year ago

For the record - added tests, updated docs before merging this. It was approved by Peter here https://github.com/iterative/gto/pull/417#issuecomment-1725376413