search

iterative / helm-charts

📦 Iterative Helm charts 🐳
https://helm.iterative.ai/
Apache License 2.0
1 stars 4 forks source link

Rename `ingress.protocol` to `ingress.scheme` in `_helpers.tpl` #202

Open 0x2b3bfa0 opened 1 year ago

0x2b3bfa0 commented 1 year ago

https://github.com/iterative/helm-charts/blob/b6439033a5c784db305b5afa77b421355d3fa186/charts/studio/templates/_helpers.tpl#L194-L196

0x2b3bfa0 commented 1 year ago

@mjasion, would it be possible to use relative paths for all the hardcoded URLs that use the template above? E.g.

https://github.com/iterative/helm-charts/blob/b6439033a5c784db305b5afa77b421355d3fa186/charts/studio/templates/configmap-studio.yaml#L12

- {{include "ingress.protocol" . }}://{{.Values.global.host }}{{- if and .Values.global.basePath (not (eq .Values.global.basePath "/")) }}/{{ include "studio.basePath" . }}{{- end }}/api
+ /api

It's probably not viable for webhooks, but yes for API_URL and UI_URL among others.

mjasion commented 1 year ago

@0x2b3bfa0 I think not now. We need to change the code of webapi and webui AFAIK.