iterative / ldb

Apache License 2.0
3 stars 0 forks source link

status: Reports deleted objects as `Additions` #463

Open daavoo opened 2 years ago

daavoo commented 2 years ago

Perhaps I am missing some more detailed explanation of expected semantics from the command summary.

Having a clean staged dataset:

$ ldb status
Workspace directory: '.'

ds:hackathon-starter
  Num data objects:     2034
  Num annotations:      2034

  auto-pull:        false

No unsaved changes.

I del some items:

$ ldb del ds:root --tag discard
Deleted 15 data objects from ds:hackathon-starter

ldb status report them as Additions?:

$ ldb status
Workspace directory: '.'

ds:hackathon-starter
  Num data objects:     2019
  Num annotations:      2019

  auto-pull:        false

Unsaved changes:
  Additions (+):       15
  Deletions (-):        0
  Modifications (m):    0

But ldb diff reports them as Deletions?:

$ ldb diff        
- id:1ab6175da97ba290f6e76e011669da69    1            ...175da97ba290f6e76e011669da69.jpeg
- id:2dfb26e7ae2aea858f3d70c200c40e5a    1            ...26e7ae2aea858f3d70c200c40e5a.jpeg
- id:650dc855813efaf79e02b34bdcf12269    1            ...c855813efaf79e02b34bdcf12269.jpeg
- id:6abe76fe5c137407bc12a868f18550e2    1            ...76fe5c137407bc12a868f18550e2.jpeg
- id:6e04ea5895e18da689003f6b4c1af3d7    1            ...ea5895e18da689003f6b4c1af3d7.jpeg
- id:778459b14bc2babfa39ab8df0ba1e3b5    1            ...59b14bc2babfa39ab8df0ba1e3b5.jpeg
- id:82f9301124038b525d9aeaeb8299f30d    1            ...301124038b525d9aeaeb8299f30d.jpeg
- id:896fed67faab9d7971fbf4c591754763    1            ...ed67faab9d7971fbf4c591754763.jpeg
- id:89ba84cacc3be0b2a758c3a9c7856c31    1            ...84cacc3be0b2a758c3a9c7856c31.jpeg
- id:8d1bdac793c76b20002f32bd4f9a070b    1            ...dac793c76b20002f32bd4f9a070b.jpeg
- id:990a493daf56b47e3d2dabdddd5187ee    1            ...493daf56b47e3d2dabdddd5187ee.jpeg
- id:aa2e559b07cfb03e4330d6e149c671dc    1            ...559b07cfb03e4330d6e149c671dc.jpeg
- id:c76a1ed74172ac034edfd881d9a73c11    1            ...1ed74172ac034edfd881d9a73c11.jpeg
- id:d8b249622c7b7e26bceceb416356bc05    1            ...49622c7b7e26bceceb416356bc05.jpeg
- id:f3565da701e8a24913be851bbc584f42    1            ...5da701e8a24913be851bbc584f42.jpeg

  Additions (+):        0
  Deletions (-):       15
  Modifications (m):    0