search

iterative / link-check

A Node-based tool to verify if links are alive. Built to be used anywhere!
4 stars 4 forks source link

Use execa instead of child_process #15

Closed rogermparent closed 2 years ago

rogermparent commented 2 years ago

This PR changes the way link check invokes git by using a library called execa over child_process.exec, the former wrapping the latter with lots of quality of life improvements like a Promise-based API, enhanced Windows support, and most importantly a vastly increased buffer limit on stored output.

This should fix the issue where the checker fails when PR diffs are massive. There are other optimizations we can do as well (only diffing relevant files comes to mind) but this solution should suffice even without those.

rogermparent commented 2 years ago

Weird! I was able to run yarn build, and run the package through a local yarn add on dvc.org, but maybe I got something tangled up in my system and that actually uses the old one. Thanks for the catch!

rogermparent commented 2 years ago

I was able to replicate that, I can definitely fix it but just need to find the best way- whether through webpack or import().

rogermparent commented 2 years ago

The initial draft of the PR was rushed dog water, but after a package update, some API fixes, and some proper testing, things actually work.

rogermparent commented 2 years ago

Good catch, I looked into it and found that an update to node_fetch added a MultipartParser class which is imported dynamically, so Webpack splits it into its own chunk by default. I'm sure some settings could force it all into one file, but it's probably best not to fight it.