Support more options to authenticate on GitHub

iterative / mlem

🐶 A tool to package, serve, and deploy any ML model on any platform. Archived to be resurrected one day🤞

https://mlem.ai

Apache License 2.0

716 stars 44 forks source link

Support more options to authenticate on GitHub #91

Open aguschin opened 2 years ago

aguschin commented 2 years ago

Right now we only support authentication in GH with GITHUB_USERNAME and GITHUB_TOKEN pair provided as env vars. We should support other methods too. By authentication I mean ability to load models from private repos, list them and do other things, e.g.

mlem ls -r https://github.com/iterative/example-mlem

aguschin commented 2 years ago

This is something that will interfere with normal usage of the tool when users do their first steps, so I would consider this between p1 and p2.

mike0sv commented 2 years ago

Authentication is required only for private repos, which is not very common for testing new tools, so my guess it's p2. As for auth methods, here are some options:

Use ssh (which is pre-authenticated most of the time) as a fallback if http request raised 404. This probably will require to clone everything to a tmp directory. This can be handled by https://github.com/iterative/scmrepo
Urls like https://user:pass@github.com/... - this should be supported by fsspec, but I have my doubts about it. Need to check

mike0sv commented 2 years ago

Tested a bit, git auth is not the same as ssh. Meaning, if you can run git clone ... successfully (because you already have credentials in your keychain, for example), it doesnt mean that ssh access (ssh://git@github.com/org/repo) will succeed. So the first bullet is about re-using git credentials

mike0sv commented 2 years ago

https://github.com/iterative/scmrepo/issues/9

aguschin commented 1 year ago

related to #616 , or even duplicate