search

iterative / setup-cml

GitHub Action for CML setup
25 stars 12 forks source link

get rid of dist #67

Closed casperdcl closed 2 years ago

casperdcl commented 2 years ago

do we really need dist/ at all? How much speedup does it really bring? Can we just run from source?^1

related: #54

dacbd commented 2 years ago

What do you mean by run from source? My understanding is the GitHub node actions basically grab that file and run it ie No npm install or other such things are run, and that's why they recommend doing it that way vs checking in node_modules.

casperdcl commented 2 years ago

I mean run from src/ not dist/

dacbd commented 2 years ago

Without committing node_modules to the repo it wouldn't work/?

casperdcl commented 2 years ago

Ah I see https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action#commit-tag-and-push-your-action-to-github - interestingly we're using https://github.com/iterative/setup-cml/blob/4d9a9f255ac51c1cca4d19e58571d637b83886ba/package.json#L57 instead of the recommended @vercel/ncc