iterative / studio-support

❓ DVC Studio Issues, Question, and Discussions
https://studio.iterative.ai
16 stars 1 forks source link

Sort numerical parameters #47

Closed daavoo closed 2 years ago

daavoo commented 2 years ago

When Parameters have numerical values, they are still recognized as a string.

This causes the sorting result to don't match what I would expect:

Captura de pantalla 2022-02-09 a las 13 22 29

The capture comes from applying sorting to the max_features param in the Studio Demo Project:

https://studio.iterative.ai/team/Iterative/views/example-get-started-zde16i6c4g?sort=param%3Bparams.yaml%3Afeaturize.max_features%3BASC

ssachkovskaya commented 2 years ago

@daavoo Thanks for you report! The issue must be fixed now. We just noticed that a menu option is still called Sort A-Z for numeric params which we will fix soon, but this is only a UI issue and you can already start using the correct numeric sort.

daavoo commented 2 years ago

Is the change deployed? The sorting doesn't appear to be working properly (from example-get-started demo):

Captura de Pantalla 2022-05-06 a las 22 03 38
jellebouwman commented 2 years ago

@daavoo the change is deployed - you are probably looking at an older parsed view where these param values are still served to the front-end as strings. Forcing a re-import should enable you to sort these params as numbers - ran into the same issue and it worked for me. 👍