iterative / terraform-provider-iterative

☁️ Terraform plugin for machine learning workloads: spot instance recovery & auto-termination | AWS, GCP, Azure, Kubernetes
https://registry.terraform.io/providers/iterative/iterative/latest/docs
Apache License 2.0
287 stars 27 forks source link

docs: `task` requirements 2 #363

Open casperdcl opened 2 years ago

casperdcl commented 2 years ago

p2

p1

DavidGOrtega commented 2 years ago

what permissions are required (e.g. port 22 open)?

This is needed for runner. task is not enforced right now to use ssh, we use the cloud storage

DavidGOrtega commented 2 years ago

This are my pics @casperdcl

As far as I see you already have some

README

Automatically destroy unused cloud resources (never forget to turn your GPU off again)

This is not true at current status unless you use runner

TERRAFORM DOCS

Create a directory named shared to store input data and output artefacts.

I do not fully undestand this example. Why should the user modify the project structure? If someone is telling me to modify my project to use a tool I would say... F*#$@ U

The script argument can take any string, including a heredoc or the contents of a file returned by the file function.

Is better if we setup an example instead (terraform docs are not great). Also is very nice the idea of using python scripting as an example

Status and events don't produce a stable output between cloud providers and are intended for human consumption only.

Right now the status is normalised

0x2b3bfa0 commented 2 years ago

This is not true at current status unless you use runner[citation needed]

As far as I can tell, iterative_task terminates all the instances as soon as the script finishes running. 🤔

0x2b3bfa0 commented 2 years ago

Add to the list https://github.com/iterative/terraform-provider-iterative/issues/258#issuecomment-977180443, “add a documentation footnote that after the task completes its instance is auto destroyed”

casperdcl commented 2 years ago

Added an item to ~the p1 checklist here~ #397 instead :)

DavidGOrtega commented 2 years ago

@casperdcl can you please add these two?

omesser commented 2 years ago

@casperdcl - suggest to add here the fix to the banner being broken here Missing banner-terraform.png

casperdcl commented 2 years ago

thx added to #450 :)

0x2b3bfa0 commented 2 years ago

Don't forget this pearl:

casperdcl commented 2 years ago

Already done https://registry.terraform.io/providers/iterative/iterative/latest/docs/guides/getting-started#debugging

0x2b3bfa0 commented 2 years ago

🙈 The sad part is that I reviewed that change.