iterative / terraform-provider-iterative

☁️ Terraform plugin for machine learning workloads: spot instance recovery & auto-termination | AWS, GCP, Azure, Kubernetes
https://registry.terraform.io/providers/iterative/iterative/latest/docs
Apache License 2.0
287 stars 27 forks source link

unify resources #461

Open casperdcl opened 2 years ago

casperdcl commented 2 years ago

Right now, functionality added to TPI resource_runner (to support CML) needs to be duplicated/separately added to TPI resource_task (for TPI task) and TPI resource_machine (for who-knows-what).

It's better to use the same code for all 3 resources:

Either:

  1. make the above resources share more golang code (abstract common functionality into one place common.go & make them all use said common functionality),
  2. Or deprecate 2 of the above resources
DavidGOrtega commented 2 years ago

@casperdcl I do not fully understand the issue. Do you mean that we have to expose task and machine resources within the cml CLI?

casperdcl commented 2 years ago

Updated description. Clearer now?