Closed dacbd closed 2 years ago
I never look at it even. That code was added long time ago. I guess that ecr_helper
was not working at all
indeed I think when I was testing it I had it differently than for the merge, condensed it for readability and it got missed. (thankfully I added so if it failed (as it often would take 10 mins to download for gcp) it wouldn't matter)
discovered during some spot instance testing 🙈