search

iterative / terraform-provider-iterative

☁️ Terraform plugin for machine learning workloads: spot instance recovery & auto-termination | AWS, GCP, Azure, Kubernetes
https://registry.terraform.io/providers/iterative/iterative/latest/docs
Apache License 2.0
288 stars 27 forks source link

`runner` setup script typo #614

Closed dacbd closed 2 years ago

dacbd commented 2 years ago

discovered during some spot instance testing 🙈

DavidGOrtega commented 2 years ago

I never look at it even. That code was added long time ago. I guess that ecr_helper was not working at all

dacbd commented 2 years ago

indeed I think when I was testing it I had it differently than for the merge, condensed it for readability and it got missed. (thankfully I added so if it failed (as it often would take 10 mins to download for gcp) it wouldn't matter)