search

iterative / terraform-provider-iterative

☁️ Terraform plugin for machine learning workloads: spot instance recovery & auto-termination | AWS, GCP, Azure, Kubernetes
https://registry.terraform.io/providers/iterative/iterative/latest/docs
Apache License 2.0
287 stars 26 forks source link

Linters? #615

Open dacbd opened 2 years ago

dacbd commented 2 years ago

aka Restyled's PR spam triggers me...

thoughts on adding github/super-linter/slim as a check for PRs and removing Restyled.

I will note that, that the linter has a bit on a laundry list... see here

0x2b3bfa0 commented 2 years ago

Note that we already have golangci-lint in place for the task directory. The iterative directory has been explicitly excluded because it has, effectively, a laundry list of issues.

Ma quel foglio che chiedete per azzardo m'è cascato. È la lista del bucato.

0x2b3bfa0 commented 2 years ago

https://github.com/iterative/terraform-provider-iterative/blob/5194dc5f68c4fa07cb2d0f7304bee58f0208f5f5/.golangci.yml#L3-L4

dacbd commented 2 years ago

I missed that 🙈, does it work with deltas natively? Perhaps it's time to include it and as future tweaks come in part of the PRs will be cleanup.

0x2b3bfa0 commented 2 years ago

does it work with deltas natively?

If you mean --new-from-rev yes.

0x2b3bfa0 commented 2 years ago

Moved to https://github.com/iterative/terraform-provider-iterative/pull/616

0x2b3bfa0 commented 2 years ago

Not sure if we need super-linter for a single language, but it's indeed a nice project. Let's ask @iterative/cml for opinions; we'll surely get plenty. 😄

dacbd commented 2 years ago

it also dectects various bits of shell scripting, GitHub actions, and others etc

0x2b3bfa0 commented 2 years ago

Sounds good. Let's lint, then. 🐑

0x2b3bfa0 commented 2 years ago

Note that running super-linter locally doesn't feel quite ergonomic. I hope we won't need to run a Docker container with a commit hook. 😈