Avoid using environment variables to alter Kubernetes task functionality

iterative / terraform-provider-iterative

☁️ Terraform plugin for machine learning workloads: spot instance recovery & auto-termination | AWS, GCP, Azure, Kubernetes

https://registry.terraform.io/providers/iterative/iterative/latest/docs

Apache License 2.0

290 stars 27 forks source link

Avoid using environment variables to alter Kubernetes task functionality #648

Open 0x2b3bfa0 opened 2 years ago

0x2b3bfa0 commented 2 years ago

Extracted from https://github.com/iterative/terraform-provider-iterative/pull/645#discussion_r952928867

Kubernetes task code uses environment variables in a rather hacky way to differentiate file transfer from code execution jobs. While this is mostly a consequence of the approach we follow, it would be nice to use function arguments or something more explicit.