search

iterative / terraform-provider-iterative

☁️ Terraform plugin for machine learning workloads: spot instance recovery & auto-termination | AWS, GCP, Azure, Kubernetes
https://registry.terraform.io/providers/iterative/iterative/latest/docs
Apache License 2.0
290 stars 27 forks source link

Implement human-readable random identifier generation #653

Closed 0x2b3bfa0 closed 2 years ago

0x2b3bfa0 commented 2 years ago

Now users can run e.g. task create --name experiment to create a task named experiment with a randomly generated suffix, avoiding clashes due to cloud providers' globally unique resource name requirements.

Note Terraform resources' behavior remains unaltered and fully backwards-compatible. This change only affects the standalone command-line tool.

tasdomas commented 2 years ago

Let's pass the tests and land this - contrary to popular belief PRs do not need time to "breathe" :)

0x2b3bfa0 commented 2 years ago

contrary to popular belief PRs do not need time to "breathe"

Pull requests probably don't, but developers do. 🤣

0x2b3bfa0 commented 2 years ago

Let me see if I can pass the tests: this pull request modifies code that is common to every “cloud” and I would like all the smoke tests to pass.

0x2b3bfa0 commented 2 years ago

It looks like Kubernetes succeeded, despite the last failed run; merging...