Support using pre-allocated blob containers in azure.

iterative / terraform-provider-iterative

☁️ Terraform plugin for machine learning workloads: spot instance recovery & auto-termination | AWS, GCP, Azure, Kubernetes

https://registry.terraform.io/providers/iterative/iterative/latest/docs

Apache License 2.0

287 stars 27 forks source link

Support using pre-allocated blob containers in azure. #660

Closed tasdomas closed 1 year ago

tasdomas commented 1 year ago

This PR contains a few other changes as well:

generic rclone connection string generation
using rclone to check that remote storage is accessible
updates to the aws and gcp providers to use the same rclone utilities.

0x2b3bfa0 commented 1 year ago

@tasdomas, would you mind setting the base branch of #660 (this) to #651 so I don't have to tweak GitHub filters too much to review only the changes it introduces?

tasdomas commented 1 year ago

@tasdomas, would you mind setting the base branch of #660 (this) to #651 so I don't have to tweak GitHub filters too much to review only the changes it introduces?

I was thinking that we'd land #651 first and then move on to this.

dacbd commented 1 year ago

@tasdomas it looks like #651 is merged, Is this ready for review now?

tasdomas commented 1 year ago

@tasdomas it looks like #651 is merged, Is this ready for review now?

It is, yes