search

iterative / terraform-provider-iterative

☁️ Terraform plugin for machine learning workloads: spot instance recovery & auto-termination | AWS, GCP, Azure, Kubernetes
https://registry.terraform.io/providers/iterative/iterative/latest/docs
Apache License 2.0
287 stars 27 forks source link

Some refactoring on leo subcommands #664

Closed tasdomas closed 1 year ago

tasdomas commented 1 year ago

Renamed delete to destroy. Renamed read to status. Restructured base options and moved all subcommands into a single package.

tasdomas commented 1 year ago

moved all subcommands into a single package

Why? thinking

Is there any reason to keep identical single file packages?

0x2b3bfa0 commented 1 year ago

Is there any reason to keep identical single file packages?

~“Namespaces are one honking great idea — let's do more of those!”~ Wrong language! 🤭

It probably boils down to a matter of taste[^1] but, to my mind, it looks cleaner once we introduce subcommands or more complex commands (e.g. #291 or #531) which may be split over several files.

See also docker/cli, kubernetes/kubectl or cli/cli for inspiration.

[^1]: Or lack thereof, you're the wise gopher here.