search

iterative / terraform-provider-iterative

☁️ Terraform plugin for machine learning workloads: spot instance recovery & auto-termination | AWS, GCP, Azure, Kubernetes
https://registry.terraform.io/providers/iterative/iterative/latest/docs
Apache License 2.0
287 stars 27 forks source link

Make smoke tests more lightweight #673

Closed tasdomas closed 1 year ago

tasdomas commented 1 year ago

Currently smoke tests call tpi to provision machines with GPUs. This often runs into resource quotas. The proposal runs PR tests provisioning smaller (m) machines and a test to provision machines with GPUS is run on a fixed daily schedule on master.

0x2b3bfa0 commented 1 year ago

Note that k8s tests will always run on a GPU-enabled cluster; to avoid this, you may want to modify the following lines:

https://github.com/iterative/terraform-provider-iterative/blob/d587a7ff720559349c42648b4a0fd9e935d3174e/.github/workflows/smoke.yml#L106-L112

See the collapsible at https://registry.terraform.io/providers/iterative/iterative/latest/docs/guides/testing-kubernetes#creating-a-test-cluster for more information:

https://github.com/iterative/terraform-provider-iterative/blob/89ff0415623a98563fcf3fcd495e64a5452b0002/docs/guides/testing-kubernetes.md?plain=1#L46-L50

0x2b3bfa0 commented 1 year ago

Unrelated wish: please increase the timeout-minutes for the text-k8s job; 30 is not enough. 🙏🏼