iterative / terraform-provider-iterative

☁️ Terraform plugin for machine learning workloads: spot instance recovery & auto-termination | AWS, GCP, Azure, Kubernetes
https://registry.terraform.io/providers/iterative/iterative/latest/docs
Apache License 2.0
287 stars 27 forks source link

Support reusing existing storage containers across task providers #687

Closed tasdomas closed 1 year ago

tasdomas commented 1 year ago

This closes #299.

The storage type is inferred by provider.

The storage config section is extended with additional options:

 storage {
    container = <container-id>
    container_path = <subdirectory in container>
    container_opts = {
    }
  }
0x2b3bfa0 commented 1 year ago

How does leo list work when using this feature? Worth shifting from storage enumeration to e.g. compute enumeration and creating the latter first?

tasdomas commented 1 year ago

How does leo list work when using this feature? Worth shifting from storage enumeration to e.g. compute enumeration and creating the latter first?

leo list will need to be updated. But I think we should rethink the approach instead of switching to listing compute instances. Unless I'm mistaken, resource groups are supported by all major cloud providers, we could use (and list) those.

0x2b3bfa0 commented 1 year ago

Unless I'm mistaken, resource groups are supported by all major cloud providers

It depends on your definition of resource group.[^1] 😅

[^1]: Tangentially related to https://github.com/iterative/terraform-provider-iterative/issues/289#issue-1062601339

0x2b3bfa0 commented 1 year ago

@tasdomas, would you mind opening an issue to track https://github.com/iterative/terraform-provider-iterative/pull/687#issuecomment-1283917216?

tasdomas commented 1 year ago

Unless I'm mistaken, resource groups are supported by all major cloud providers

It depends on your definition of resource group.1 sweat_smile

Footnotes

1. Tangentially related to [Allow tasks to destroy themselves #289 (comment)](https://github.com/iterative/terraform-provider-iterative/issues/289#issue-1062601339) [leftwards_arrow_with_hook](#user-content-fnref-1-0d2c7bd068cff5611d0349f0c7a4d25e)

Done. Thanks for reminding me!