search

iterative / terraform-provider-iterative

☁️ Terraform plugin for machine learning workloads: spot instance recovery & auto-termination | AWS, GCP, Azure, Kubernetes
https://registry.terraform.io/providers/iterative/iterative/latest/docs
Apache License 2.0
287 stars 27 forks source link

Use `d.Id()` instead of `d.Get("name")` as identifier for Google Cloud #694

Closed 0x2b3bfa0 closed 1 year ago

0x2b3bfa0 commented 1 year ago

Inconsistent with the other providers and a potential source of issues:

https://github.com/iterative/terraform-provider-iterative/blob/2b46b50aabf249efc19a7f3de6a87a95ef2c5a19/iterative/gcp/provider.go#L34

https://github.com/iterative/terraform-provider-iterative/blob/2b46b50aabf249efc19a7f3de6a87a95ef2c5a19/iterative/gcp/provider.go#L284

Would also eliminate the need for the name option when destroying runners:

https://github.com/iterative/terraform-provider-iterative/blob/2b46b50aabf249efc19a7f3de6a87a95ef2c5a19/cmd/leo/destroyrunner/destroyrunner.go#L36